pr_labeler: add warning for porting_guides changes #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
added
backport-2.15
github-actions
bot
added
the
needs_triage
felixfontein
reviewed
Oct 4, 2023
samccann
removed
the
needs_triage
samccann
reviewed
Oct 4, 2023
gotmax23
force-pushed
the
porting_guide_changes
branch
from
d6c5912 to
ae2ec36
Compare
gotmax23
added
no_backport
|
Okay, this should be ready for another review. The list of release managers are no longer hardcoded. Now that we have the Github app token set up, we can retrieve the list of release managers from @ansible/release-management-wg via the Github API 🎉. This no longer applies to core porting guides; warnings are only printed for changes to community porting guides. There is deliberately no distinction between current and EOL changelogs. |
samccann
approved these changes
Oct 18, 2023
This adds a warning message when PRs are created that edit porting_guides by someone outside of the Release Management WG. These files are automatically generated during the ansible release process and should not be modified. Fixes: ansible#503
Instead of hardcoding the list of release managers, we can use the Github API to retrieve the members of the `@ansible/release-management-wg` team.
For example, patchback is not a release manager, but we still want it to backport Porting Guide PRs.
Co-authored-by: Sandra McCann <[email protected]>
gotmax23
force-pushed
the
porting_guide_changes
branch
from
1e150ac to
95ece7e
Compare
|
Thanks for the review, @samccann! |
|
I just rebased on top of |
|
Note to self: I tagged this PR with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning message when PRs are created that edit
porting_guides by someone outside of the Release Management WG. These
files are automatically generated during the ansible release process and
should not be modified.
Fixes: #503